Does a person who dies by suicide always have no share in the World to Come?

Shalom uveracha,

1. If that person had the status of one who takes his own life intentionally, he has no share in the World to Come. However, one who, because of emotional distress, became confused and was not of sound mind, does have a share in the World to Come.

Even in a case where he has no share in the World to Come, the meaning is that he has no known share of his own, but nevertheless he is sustained and benefits from some of the hidden treasures of charity set aside for those who did not merit, like a poor man who has nothing to eat and relies on his fellow's table (Responsa Yabia Omer, part 6, Yoreh Deah, siman 36).

2. There is great benefit in reciting Kaddish, Torah study, and acts of charity done for the elevation of the soul of the deceased who took his own life and destroyed his life with his own hand, and therefore it is a mitzvah for his relatives to say the haftarah in public, the hashkavah, and a prayer for the elevation of his soul (ibid.).

Good news,

Hillel Meirs